Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): Add some execution cases to EOF test tracker #727

Merged
merged 4 commits into from
Aug 6, 2024
Merged

fix(docs): Add some execution cases to EOF test tracker #727

merged 4 commits into from
Aug 6, 2024

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Aug 1, 2024

🗒️ Description

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

marioevz
marioevz approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz changed the title Add some execution cases to EOF test tracker fix(docs): Add some execution cases to EOF test tracker Aug 6, 2024
@marioevz marioevz merged commit 05da2d9 into ethereum:main Aug 6, 2024
4 checks passed
@marioevz marioevz deleted the eof-tracker-execution branch August 6, 2024 17:19
spencer-tb pushed a commit to spencer-tb/execution-spec-tests that referenced this pull request Aug 8, 2024
@gumb0 @spencer-tb
fix(docs): Add some execution cases to EOF test tracker (ethereum#727)
e624001 
* Add EIP-4200 execution cases to EOF tracker

* Add EIP-4750 execution cases to EOF tracker

* Add EIP-5450 execution case to EOF tracker

* Mark EIP-4200 execution cases covered
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gumb0 @marioevz