-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature & Refactor: Add Concurrency and Filler Skips to Improve tf
Effienciency. Additional CLI arguments.`
#72
Merged
spencer-tb
merged 12 commits into
ethereum:main
from
spencer-tb:tf-concurrency-cache-usage
Mar 8, 2023
Merged
Feature & Refactor: Add Concurrency and Filler Skips to Improve tf
Effienciency. Additional CLI arguments.`
#72
spencer-tb
merged 12 commits into
ethereum:main
from
spencer-tb:tf-concurrency-cache-usage
Mar 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioevz
reviewed
Mar 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing!
Only a few comments.
Thanks!
Co-authored-by: Mario Vega <[email protected]>
…ent for serial execution.
marioevz
reviewed
Mar 7, 2023
spencer-tb
changed the title
Feature: Add Concurrency and Cache Usage to
Feature & Refactor: Add Concurrency and Filler Skips to Improve Mar 7, 2023
tf
. Additional CLI argument --benchmark
tf
Effienciency. Additional CLI arguments.`
To summarise, we now have a refactor of
With the following features:
|
marioevz
reviewed
Mar 7, 2023
marioevz
approved these changes
Mar 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves our run time of
tf
from ~15s to ~5s.So far I've added an additional function called
parallel_fill
that is equivalent tofill
but with concurrency, as well as a--benchmark
CLI argument that logs the run time oftf
.To test for yourself you will need to edit
filler.fill()
in main and switch betweenfiller.parallel_fill()
. Usingtf --benchmark
to log the times.fill()
:parallel_fill()
: