Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(tests): EOF - EIP-6206: Runtime stack overflow at JUMPF #690

Merged
merged 2 commits into from
Jul 19, 2024
Merged

new(tests): EOF - EIP-6206: Runtime stack overflow at JUMPF #690

merged 2 commits into from
Jul 19, 2024

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Jul 18, 2024

🗒️ Description

Tests for runtime stack overflow at JUMPF instruction. Similar to #678.

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@gumb0 gumb0 requested a review from marioevz July 18, 2024 13:46
marioevz
marioevz approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one comment but I think it should be followed up in a different PR.

tests/prague/eip7692_eof_v1/eip6206_jumpf/test_jumpf_execution.py Show resolved Hide resolved
@marioevz marioevz mentioned this pull request Jul 19, 2024
Open
@marioevz marioevz force-pushed the eof-jumpf-runtime-stack-overflow branch from d0509f9 to d42ae10 Compare July 19, 2024 21:06
@marioevz
Copy link
Member

Rebased to see if that fixes the CI issues. Will merge afterwards.

@marioevz marioevz merged commit e7fb7d8 into ethereum:main Jul 19, 2024
4 checks passed
@marioevz marioevz deleted the eof-jumpf-runtime-stack-overflow branch July 19, 2024 21:16
@pdobacz pdobacz mentioned this pull request Jul 22, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

@shemnon shemnon shemnon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gumb0 @marioevz @shemnon