Fixture Format: Add descriptive name to every fixture test. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In reality, the hive name of the test case should not be E.g. a test in fixture: should be included as test case: in hive. |
|
The above commits achieve the following:
╰─>$ tf --output="fixtures"
DEBUG:ethereum_test_filling_tool.main:searching withdrawals.withdrawals for fillers
DEBUG:ethereum_test_filling_tool.main:searching eips.eip3651 for fillers
DEBUG:ethereum_test_filling_tool.main:searching eips.eip3855 for fillers
DEBUG:ethereum_test_filling_tool.main:searching eips.eip3860 for fillers
DEBUG:ethereum_test_filling_tool.main:searching vm.chain_id for fillers
DEBUG:ethereum_test_filling_tool.main:searching vm.dup for fillers
DEBUG:ethereum_test_filling_tool.main:searching example.example for fillers
INFO:ethereum_test_filling_tool.main:collected 20 fillers
DEBUG:ethereum_test_filling_tool.main:filling - withdrawals.withdrawals.use_value_in_tx
DEBUG:ethereum_test_filling_tool.main:filling - withdrawals.withdrawals.use_value_in_contract
DEBUG:ethereum_test_filling_tool.main:filling - withdrawals.withdrawals.balance_within_block
DEBUG:ethereum_test_filling_tool.main:filling - withdrawals.withdrawals.multiple_withdrawals_same_address
DEBUG:ethereum_test_filling_tool.main:filling - withdrawals.withdrawals.many_withdrawals
DEBUG:ethereum_test_filling_tool.main:filling - withdrawals.withdrawals.self_destructing_account
DEBUG:ethereum_test_filling_tool.main:filling - withdrawals.withdrawals.newly_created_contract
DEBUG:ethereum_test_filling_tool.main:filling - withdrawals.withdrawals.no_evm_execution
DEBUG:ethereum_test_filling_tool.main:filling - withdrawals.withdrawals.zero_amount
DEBUG:ethereum_test_filling_tool.main:filling - withdrawals.withdrawals.large_amount
DEBUG:ethereum_test_filling_tool.main:filling - eips.eip3651.warm_coinbase_call_out_of_gas
DEBUG:ethereum_test_filling_tool.main:filling - eips.eip3651.warm_coinbase_gas_usage
DEBUG:ethereum_test_filling_tool.main:filling - eips.eip3855.push0
DEBUG:ethereum_test_filling_tool.main:filling - eips.eip3860.initcode_limit_contract_creating_tx
DEBUG:ethereum_test_filling_tool.main:filling - eips.eip3860.initcode_limit_contract_creating_tx_gas_usage
DEBUG:ethereum_test_filling_tool.main:filling - eips.eip3860.initcode_limit_create_opcode
DEBUG:ethereum_test_filling_tool.main:filling - eips.eip3860.initcode_limit_create2_opcode
DEBUG:ethereum_test_filling_tool.main:filling - vm.chain_id.chain_id
DEBUG:ethereum_test_filling_tool.main:filling - vm.dup.dup
DEBUG:ethereum_test_filling_tool.main:filling - example.example.yul |
|
Here is a list of every hive test name using the current state of this PR:
|
marioevz
approved these changes
Mar 2, 2023
|
Here is the new list:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a lot of tests have a duplicate name:
000_shanghai, among others depending on the fork of the test fixture. When running tests in hive this makes it difficult to determine what tests are throwing errors.This PR makes sure every test has its own distinguishable name. It will help aid using
--sim-limitwithin the hive simulation: ethereum/hive#732.