Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(tests) EXT*CALL input data validation #685

Merged
merged 4 commits into from
Jul 17, 2024
Merged

new(tests) EXT*CALL input data validation #685

merged 4 commits into from
Jul 17, 2024

Conversation

shemnon
Copy link
Collaborator

@shemnon shemnon commented Jul 15, 2024

🗒️ Description

Tests to validate that inputdata passed into EXT*CALL operations is handled correctly.

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@shemnon
new(tests) EXT*CALL input data validation
ea8fe74 
Test to validate that inputdata is passed in correctly from memory.

Signed-off-by: Danno Ferrin <[email protected]>
marioevz
marioevz reviewed Jul 16, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, thanks!

tests/prague/eip7692_eof_v1/eip7069_extcall/test_calldata.py Outdated Show resolved Hide resolved
tests/prague/eip7692_eof_v1/eip7069_extcall/test_calldata.py Show resolved Hide resolved
@shemnon
add calldata subcall tests
c309775 
Signed-off-by: Danno Ferrin <[email protected]>
marioevz
marioevz approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small suggestion. Thanks!

tests/prague/eip7692_eof_v1/eip7069_extcall/test_calldata.py Outdated Show resolved Hide resolved
shemnon added 2 commits July 16, 2024 20:50
@shemnon
use opcode defaults for gas
2631afa 
Signed-off-by: Danno Ferrin <[email protected]>
@shemnon
clean up imports
ad88d03 
Signed-off-by: Danno Ferrin <[email protected]>
@shemnon shemnon merged commit 4520ea7 into ethereum:main Jul 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shemnon @marioevz