Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): EOF - EIP-4200: Organize code_validation_jump.py tests #666

Merged
merged 3 commits into from
Jul 4, 2024
Merged

fix(tests): EOF - EIP-4200: Organize code_validation_jump.py tests #666

merged 3 commits into from
Jul 4, 2024

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Jul 3, 2024 •
edited
Loading

🗒️ Description

Remove container validation tests from tests/prague/eip7692_eof_v1/eip3540_eof_v1/code_validation_jump.py into proper files in tests/prague/eip7692_eof_v1/eip4200_relative_jumps.

Creates new exception EOFException.STACK_HEIGHT_MISMATCH.

🔗 Related Issues

None.

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added the scope:tests Scope: Test cases label Jul 3, 2024
@marioevz marioevz requested review from shemnon and chfast July 3, 2024 20:35
@marioevz marioevz force-pushed the organize_code_validation_jump_tests branch from 4c996e3 to eba1016 Compare July 3, 2024 20:36
pdobacz
pdobacz reviewed Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@pdobacz pdobacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marioevz marioevz merged commit 12ceb22 into ethereum:main Jul 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdobacz pdobacz pdobacz left review comments

@chfast chfast chfast approved these changes

@shemnon shemnon Awaiting requested review from shemnon

Assignees
No one assigned
Labels
scope:tests Scope: Test cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marioevz @chfast @pdobacz