-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(tests): EOF - EIP-3540: test all opcodes in valid code section #634
Conversation
77ae17b
to
6112be7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic, thanks!
tests/prague/eip7692_eof_v1/eip3540_eof_v1/test_all_opcodes_in_container.py
Outdated
Show resolved
Hide resolved
Hi, I think all tests can benefit from UndefinedOpcodes enum. the tox error:
is this related to my code or a global issue? |
Global issue, I'll help rebase because I just merged a big PR π |
if opcode is halting in eof, let it act as returning opcode to check that no exception happens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
) * test all opcodes in valid eof code section * make UndefinedOpcodes global * do not produce unreachable code on halting instructions if opcode is halting in eof, let it act as returning opcode to check that no exception happens * types fix after rebase * changelog * feat(fw): implement hash for bytecode * fix(tests): remove ._name_ --------- Co-authored-by: Mario Vega <[email protected]>
ποΈ Description
Put every instruction with valid stack / data in between a valid eof code section
π Related Issues
β Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.