-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fw/consume): write the test class & function docstrings to _info["description"]
for use in hive reports
#579
feat(fw/consume): write the test class & function docstrings to _info["description"]
for use in hive reports
#579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this! Added a couple comments :)
@spencer-tb Here's the size difference in fixture directories with and without "description" and "url" fields. Seems reasonable, imo.
|
This is awesome 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far! Some very subtle comments.
This reverts commit cffb871.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
You can apply or discard the comment I made.
🗒️ Description
This PR:
description
" and "url
" in the_info
section.description
contains the current test class and test function docstrings concatenated.url
provides a permalink to the test function python source on Github.HiveTest
in thepytest_hive
plugin. This makes a test description available in HiveView.This will blow up the size of the test fixtures a bit and heavily parametrized fixtures will contain a lot of duplicate information.
This does not attempt to solve the problem of documenting test parametrizations, but this approach could be extended in the future to accommodate for better documentation of parametrized test cases.
Fixture Example
Consume/Hive Test Report Description Example
Todo
hiveview
.hiveview
test display name (just use consume pytest test id).🔗 Related Issues
None
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.