Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add EOFException.INVALID_DATALOADN_INDEX #560

Merged
merged 1 commit into from
May 15, 2024
Merged

add EOFException.INVALID_DATALOADN_INDEX #560

merged 1 commit into from
May 15, 2024

Conversation

chfast
Copy link
Member

@chfast chfast commented May 15, 2024 •
edited
Loading

🗒️ Description

Recognize new error code of eofparse: invalid_dataloadn_index.

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

marioevz
marioevz approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marioevz marioevz merged commit aa1a571 into ethereum:main May 15, 2024
5 checks passed
@chfast chfast deleted the eof/invalid_dataloadn_index branch May 15, 2024 15:53
spencer-tb pushed a commit to spencer-tb/execution-spec-tests that referenced this pull request May 20, 2024
@chfast @spencer-tb
fix(fw): EOF - add EOFException.INVALID_DATALOADN_INDEX (ethereum#560)
d1228d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chfast @marioevz