chore(fw): Utilize an EthRPC class within consume rlp #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencer-tb
added
type:chore
spencer-tb
force-pushed
the
consume-rpc
branch
2 times, most recently
from
fc730ff to
e6ca06e
Compare
danceratopz
reviewed
May 15, 2024
Update docs/CHANGELOG.md Co-authored-by: danceratopz <[email protected]> chore: remove jwt auth as not used within `eth_` RPC calls. chore: move BlockNumberType to init file. chore: add 8545 specifically for the EthRPC class. Update src/ethereum_test_tools/rpc/rpc.py Co-authored-by: Mario Vega <[email protected]> Update src/ethereum_test_tools/rpc/rpc.py Co-authored-by: Mario Vega <[email protected]> Update src/ethereum_test_tools/rpc/rpc.py Co-authored-by: danceratopz <[email protected]> feat(fw): update rpc methods.
spencer-tb
added a commit
to spencer-tb/execution-spec-tests
that referenced
this pull request
May 20, 2024
) Update docs/CHANGELOG.md Co-authored-by: danceratopz <[email protected]> chore: remove jwt auth as not used within `eth_` RPC calls. chore: move BlockNumberType to init file. chore: add 8545 specifically for the EthRPC class. Update src/ethereum_test_tools/rpc/rpc.py Co-authored-by: Mario Vega <[email protected]> Update src/ethereum_test_tools/rpc/rpc.py Co-authored-by: Mario Vega <[email protected]> Update src/ethereum_test_tools/rpc/rpc.py Co-authored-by: danceratopz <[email protected]> feat(fw): update rpc methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Adds the EthRPC class alongside the BaseRPC class. The latter are used within
tests_consume/test_via_rlp.py, and will be extended for consume engine.I added this withinsrc/pytest_plugins/consume/json_rpc.pybut open to moving this somewhere else.Moved to:
src/ethereum_test_tools/rpc/rpc.py🔗 Related Issues
None
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.