Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): EIP-6110, EIP-7002, EIP-7685: General purpose execution layer requests, Deposits on Chain, EL Withdrawals #530

Merged
merged 7 commits into from
May 24, 2024

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Apr 26, 2024

🗒️ Description

Contains tests for the following EIPs:

  • EIP-6110: Supply validator deposits on chain
  • EIP-7002: Execution layer triggerable withdrawals
  • EIP-7685: General purpose execution layer requests

EVM commit:
lightclient/go-ethereum@251ef62

🔗 Related Issues

#498

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz changed the title [WIP] new(tests): EIP-7002: Execution layer triggerable withdrawals [WIP] new(tests): EIP-7685: General purpose execution layer requests Apr 27, 2024
@marioevz marioevz force-pushed the eip-7685 branch 3 times, most recently from d4466b9 to 9bf1224 Compare May 3, 2024 17:21
@marioevz marioevz changed the title [WIP] new(tests): EIP-7685: General purpose execution layer requests new(tests): EIP-6110, EIP-7002, EIP-7685: General purpose execution layer requests, Deposits on Chain, EL Withdrawals May 17, 2024
@marioevz marioevz marked this pull request as ready for review May 17, 2024 13:43
@marioevz marioevz added scope:tests Scope: Test cases type:feat type: Feature labels May 17, 2024
@marioevz marioevz force-pushed the eip-7685 branch 3 times, most recently from 514dd5f to 83fcdbe Compare May 17, 2024 14:37
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I added some small refactor comments and some additional test case options. Feel free to include or leave them out.

I like that these can all be tested within 1/2 test functions. It's easy to see what it being tested :)

Like with the other EIPs, maybe we should add cases where we "try" to make a withdrawal/deposit request pre-fork.

We should take note of the 3 TODO's in the PR before merging.

tests/prague/eip6110_deposits/test_deposits.py Outdated Show resolved Hide resolved
tests/prague/eip6110_deposits/test_deposits.py Outdated Show resolved Hide resolved
docs/CHANGELOG.md Outdated Show resolved Hide resolved
@marioevz marioevz merged commit 0470295 into main May 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tests Scope: Test cases type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants