-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(tests): EIP-6110, EIP-7002, EIP-7685: General purpose execution layer requests, Deposits on Chain, EL Withdrawals #530
Conversation
d4466b9
to
9bf1224
Compare
514dd5f
to
83fcdbe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I added some small refactor comments and some additional test case options. Feel free to include or leave them out.
I like that these can all be tested within 1/2 test functions. It's easy to see what it being tested :)
Like with the other EIPs, maybe we should add cases where we "try" to make a withdrawal/deposit request pre-fork.
We should take note of the 3 TODO's in the PR before merging.
🗒️ Description
Contains tests for the following EIPs:
EVM commit:
lightclient/go-ethereum@251ef62
🔗 Related Issues
#498
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.