Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple tests for DATA* series opcodes #518

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

shemnon
Copy link
Collaborator

@shemnon shemnon commented Apr 19, 2024

🗒️ Description

Creates a set of containers and tests DATA* operations along
the test boundaries of zero, too little, just right, and
more than enough.

Signed-off-by: Danno Ferrin [email protected]

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@shemnon shemnon force-pushed the eof/dataload-operation branch 2 times, most recently from 5cd3309 to 2417f3a Compare April 20, 2024 04:56
@shemnon shemnon marked this pull request as ready for review April 22, 2024 14:35
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests!

I think it generally looks good, just some comments that I think will make the tests more readable, and I think these should apply to future EOF tests too.

tests/prague/eip7480_data_section/test_code_validation.py Outdated Show resolved Hide resolved
tests/prague/eip7480_data_section/test_code_validation.py Outdated Show resolved Hide resolved
tests/prague/eip7480_data_section/test_data_opcodes.py Outdated Show resolved Hide resolved
tests/prague/eip7480_data_section/test_data_opcodes.py Outdated Show resolved Hide resolved
tests/prague/eip7480_data_section/test_data_opcodes.py Outdated Show resolved Hide resolved
tests/prague/eip7480_data_section/test_data_opcodes.py Outdated Show resolved Hide resolved
tests/prague/eip7480_data_section/test_data_opcodes.py Outdated Show resolved Hide resolved
Creates a set of containers and tests DATA* operations along
the test boundaries of zero, too little, just right, and
more than enough.  Including validation tests.

Signed-off-by: Danno Ferrin <[email protected]>
@shemnon shemnon force-pushed the eof/dataload-operation branch from 2417f3a to 5804d31 Compare April 22, 2024 21:03
@shemnon
Copy link
Collaborator Author

shemnon commented Apr 22, 2024

Changes applied. Besu still passes all.

@shemnon shemnon requested a review from marioevz April 22, 2024 21:03
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz merged commit a6a720f into ethereum:main Apr 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants