-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple tests for DATA* series opcodes #518
Conversation
5cd3309
to
2417f3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tests!
I think it generally looks good, just some comments that I think will make the tests more readable, and I think these should apply to future EOF tests too.
Creates a set of containers and tests DATA* operations along the test boundaries of zero, too little, just right, and more than enough. Including validation tests. Signed-off-by: Danno Ferrin <[email protected]>
2417f3a
to
5804d31
Compare
Changes applied. Besu still passes all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
🗒️ Description
Creates a set of containers and tests DATA* operations along
the test boundaries of zero, too little, just right, and
more than enough.
Signed-off-by: Danno Ferrin [email protected]
🔗 Related Issues
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.