Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --traces support to besu #511

Merged
merged 1 commit into from
May 1, 2024
Merged

Conversation

shemnon
Copy link
Collaborator

@shemnon shemnon commented Apr 16, 2024

🗒️ Description

Add support for adding traces to output for besu executions.

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@shemnon shemnon force-pushed the besu/trace-support branch from 5c37ca9 to 5e5b512 Compare April 16, 2024 16:08
@shemnon
Copy link
Collaborator Author

shemnon commented Apr 16, 2024

Besu support requires this commit: hyperledger/besu@9601456 - which will likely be the first release after 24.4.0 either 24.4.1 or 24.5.0

@shemnon shemnon marked this pull request as ready for review April 16, 2024 16:11
Add support for adding traces to output when using Besu.

Signed-off-by: Danno Ferrin <[email protected]>
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marioevz marioevz merged commit 70d29ab into ethereum:main May 1, 2024
5 checks passed
danceratopz added a commit to danceratopz/execution-spec-tests that referenced this pull request May 1, 2024
shemnon added a commit to shemnon/execution-spec-tests that referenced this pull request May 13, 2024
Add support for adding traces to output when using Besu.

Signed-off-by: Danno Ferrin <[email protected]>
shemnon pushed a commit to shemnon/execution-spec-tests that referenced this pull request May 13, 2024
marioevz added a commit that referenced this pull request May 28, 2024
* new(test): add tests for EOF/EIP-663 DUPN SWAPN

* improve code generation

* chore(ci): Update workflow actions to use Node.js 20 versions (#527)

* chore(ci): Update workflow actions to use Node.js 20 versions.

* chore: Add changelog.

* Add --traces support to besu (#511)

Add support for adding traces to output when using Besu.

Signed-off-by: Danno Ferrin <[email protected]>

* feat(fw): call `evmone-eofparse` on generated EOF fixtures in fill (#519)

Co-authored-by: Dimitry Kh <[email protected]>
Co-authored-by: danceratopz <[email protected]>

* docs(fix): small fix to tracing report in readme cf #511 (#539)

* fix EOF return stack tests

The tests were previously corrected against a bug in Besu,

Signed-off-by: Danno Ferrin <[email protected]>

* EXCHANGE

Exercise exchange operation

Signed-off-by: Danno Ferrin <[email protected]>

* speling

Signed-off-by: Danno Ferrin <[email protected]>

* move

Signed-off-by: Danno Ferrin <[email protected]>

* feat(fw): Add EXCHANGE encoder

* new(tests): EOF - EIP-663: Invalid container due to invalid exchange

---------

Signed-off-by: Danno Ferrin <[email protected]>
Co-authored-by: Paweł Bylica <[email protected]>
Co-authored-by: spencer <[email protected]>
Co-authored-by: Mario Vega <[email protected]>
Co-authored-by: Dimitry Kh <[email protected]>
Co-authored-by: danceratopz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants