Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: Mark Cancun fork as deployed #489

Merged
merged 9 commits into from
Apr 10, 2024
Merged

all: Mark Cancun fork as deployed #489

merged 9 commits into from
Apr 10, 2024

Conversation

marioevz
Copy link
Member

🗒️ Description

  • Updates:
    • ethereum_test_forks
    • ethereum_test_tools, including a yul compiler code cleanup
    • ethereum_test_tools tests
    • github workflows
    • tox update to use Prague as development
    • vscode recommended files
    • minor changes to the docs

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added scope:evm Scope: evm_transition_tool package scope:forks Scope: ethereum_test_forks package scope:docs Scope: Documentation scope:ci Scope: Continuous Integration type:chore Type: Chore labels Mar 29, 2024
@marioevz marioevz requested a review from danceratopz March 29, 2024 21:59
danceratopz
danceratopz reviewed Apr 8, 2024
View reviewed changes
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Also like the Yul refactor you snuck in 🙂 Just one minor nit.

src/ethereum_test_tools/code/yul.py Outdated Show resolved Hide resolved
src/ethereum_test_tools/code/yul.py Show resolved Hide resolved
@marioevz
Copy link
Member Author

marioevz commented Apr 9, 2024

LGTM!

Also like the Yul refactor you snuck in 🙂 Just one minor nit.

Yeah, it was necessary I swear 😅

The problem was that the tests were failing without this due to solc not supporting cancun as fork.

@marioevz marioevz mentioned this pull request Apr 9, 2024
Closed
danceratopz
danceratopz approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@danceratopz danceratopz merged commit b7499ed into main Apr 10, 2024
9 checks passed
@marioevz marioevz deleted the cancun-deployed branch April 10, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danceratopz danceratopz danceratopz approved these changes

Assignees
No one assigned
Labels
scope:ci Scope: Continuous Integration scope:docs Scope: Documentation scope:evm Scope: evm_transition_tool package scope:forks Scope: ethereum_test_forks package type:chore Type: Chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marioevz @danceratopz