-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement: Fixture generation split based on hive specificity #301
Conversation
4b22473
to
1846843
Compare
1846843
to
f0c16b5
Compare
…d specific fixture output.
…ith distict fixture generation.
e4fd95d
to
139f277
Compare
Tests for the hive fixture format have been added for reference, for any additional changes. The hive fixture format is consumable in the pyspec simulator - tagging: ethereum/hive#844 These have been updated for both solc version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We can leave the fixture refactor for a follow up PR.
This PR updates fixture generation such that it is split into 2 seperate formats. The format is determined by the
--enable-hive
flag:--disable-hive
flag has been replaced by the--enable-hive
flag. I decided to flip this due to increasing queries about the extra hive fields within the fixtures.--enable-hive
flag, the default format is used. Client teams use this within there CI/CD.--enable-hive
an new fixture format is generated, similar to the current but only with the fields required by the hive pyspec simulator.Note: after we merge this PR we will have to start including 2 tar files within every new release. One for the default fixture format
fixtures.tar.gz
and another for the hive fixture formatfixtures_hive.tar.gz
.