Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/cancun: Add test scenario where the beacon root contract is missing #284

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Sep 1, 2023

Changes included

Adds a simple test where the expected beacon root contract is not present in the state before the Cancun fork, and verify that the storage for this address is not updated, nor that the calls performed to it return any value, nor that the client reaches an exception or error.

Requires #283 Merged.

@marioevz marioevz marked this pull request as draft September 1, 2023 03:54
@marioevz marioevz force-pushed the no-beacon-root-contract-tests branch from e6ef73e to ebac088 Compare September 1, 2023 17:13
@marioevz marioevz marked this pull request as ready for review September 1, 2023 17:13
@marioevz marioevz force-pushed the no-beacon-root-contract-tests branch from ebac088 to 91c890d Compare September 1, 2023 17:20
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice test case :)

@spencer-tb spencer-tb merged commit 3fec884 into ethereum:main Sep 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants