feature: Add engine API execution payload information in fixtures #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencer-tb
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
Thanks for adding this! I was able to remove so many lines in the pyspec simulator as a result 💯
I think we could add a flag for this in the future. If at some point by default we generate the original StateTest format when running fill in the future we could add the --hive or --pyspec flag for generating these fixtures with the payloads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows tests to specify the metadata that describes how each block in a blockchain test should be delivered through the Engine API, which is used in hive testing.
The forks now also have information about the versions of the Engine API endpoints that should be used with all the payloads generated for them.
Currently only
engine_newPayloadVXis supported.