Skip to content

Commit

Permalink
Exclude empty requests data in commitment (EIP-7685)
Browse files Browse the repository at this point in the history
Apply the [EIP-7685 update] included in [pectra-devnet-5].

[EIP-7685 update]: ethereum/EIPs#8989
[pectra-devnet-5]: https://notes.ethereum.org/@ethpandaops/pectra-devnet-5
  • Loading branch information
chfast committed Jan 7, 2025
1 parent a22ef72 commit bc82185
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions test/state/requests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,8 @@ hash256 calculate_requests_hash(std::span<const Requests> block_requests_list)

for (const auto& requests : block_requests_list)
{
// TODO recent change in the spec, uncomment for devnet-5
// if (requests.data.empty())
// continue;
if (requests.data().empty())
continue; // Skip empty requests.

Check warning on line 24 in test/state/requests.cpp

View check run for this annotation

Codecov / codecov/patch

test/state/requests.cpp#L23-L24

Added lines #L23 - L24 were not covered by tests

hash256 requests_hash;
crypto::sha256(reinterpret_cast<std::byte*>(requests_hash.bytes),
Expand Down

0 comments on commit bc82185

Please sign in to comment.