C++: Support zero literal (0x0_address) #682
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #682 +/- ##
==========================================
+ Coverage 93.17% 93.20% +0.03%
==========================================
Files 25 25
Lines 3779 3784 +5
Branches 391 392 +1
==========================================
+ Hits 3521 3527 +6
Misses 147 147
+ Partials 111 110 -1 |
axic
commented
Feb 13, 2023
| @@ -289,7 +289,8 @@ namespace literals | |||
| template <typename T> | |||
| constexpr T parse(std::string_view s) noexcept | |||
| { | |||
| return from_hex<T>(s).value(); | |||
| auto const v = from_hex<T>(s); | |||
There was a problem hiding this comment.
The failure case is also used for parsing errors, including odd nibbles.
Need to rethink.
gumb0
reviewed
Feb 28, 2023
| @@ -149,6 +149,12 @@ TEST(cpp, std_hash) | |||
| std::fill_n(eb.bytes, sizeof(eb), uint8_t{0xee}); | |||
| EXPECT_EQ(std::hash<evmc::bytes32>{}(eb), static_cast<size_t>(0xbb14e5c56b477375)); | |||
|
|
|||
| const auto zero_address = 0x0_address; | |||
| EXPECT_EQ(zero_address, evmc::address{}); | |||
There was a problem hiding this comment.
These can be static_asserts I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.