Fixed: some touched accounts were not verified for eip161 deletion

[zilm13]

Let's clarify
ethereum/EIPs#161

An account changes state when:

1. it is the target or refund of a SUICIDE operation for zero or more value;
2. it is the source or destination of a CALL operation or message-call transaction transferring zero or more value;
3. it is the source or newly-creation of a CREATE operation or contract-creation transaction endowing zero or more value;
4. as the block author ("miner") it is recipient of block-rewards or transaction-fees of zero or more.

Looks like we could answer YES on all of this, but you'd better check too. So:

• Do we now check and merge results of all cases?
• Should we move touched accounts to ProgramResult?

[zilm13]

@Nashatyrev should fix #622

[coveralls]

Coverage increased (+0.2%) to 57.131% when pulling ea856dd on fix/receipt-hash-622 into ee31a28 on develop.

[Nashatyrev]

Do we now check and merge results of all cases?

I added merge for regular call but forgot about create. Do you mean any other cases?

Should we move touched accounts to ProgramResult?

Yep probably. Also it is possible that we shouldn't add touched accounts in case of throw. But if this will work on live then it actually doesn't matter much, since all accounts are cleared now and this execution branch will not be executed anymore

[zilm13]

I added merge for regular call but forgot about create. Do you mean any other cases?

Just asking you to check it too according to specs to clarify that we didn't forgot anything else.

Also it is possible that we shouldn't add touched accounts in case of throw.

Yeah, that's why I've asked about ProgramResult. So I will refactor it a bit now.

[zilm13]

Please, check

[Nashatyrev]

M.b. make it a part of ProgramResult.merge() ?

[coveralls]

Coverage increased (+0.01%) to 56.99% when pulling 0861487 on fix/receipt-hash-622 into ee31a28 on develop.

[zilm13]

@Nashatyrev Updated to use merge