This repository has been archived by the owner on Oct 17, 2022. It is now read-only.
Remove unused highlight.js themes #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reviewing the CSS and noticed 3 different themes for highlight.js:
github.css(included in the minified CSS but overridden by default.css)solarized_light.css(inside the repository but not used at all)default.css(not inside the repository but CDN version is used overriding github.css)I removed
github.cssandsolarized_light.cssbecause it won't affect the current website.If another theme is preferred, I think it should be linked only here https://github.com/ethereum/ethereum-org/blob/master/views/layout.jade#L36 for simplicity.