Migrate wallets.tsx page to Chakra
#9500
Conversation
ameeetgaikwad
requested review from
samajammin,
wackerow,
corwintines,
pettinarip,
minimalsm and
jmcook1186
as code owners
github-actions
bot
added
content 🖋️
✅ ethereum-org-website-dev deploy preview ready
|
ameeetgaikwad
changed the title
wallets.tsx page to Chakra
There was a problem hiding this comment.
Thanks for the PR @ameeetgaikwad
The overall result looks good but there are a few things we would like to add on this migration. Like deprecating the components from SharedStyledComponents.
Then, there are a few spacing differences I see, comparing it with the production version, that would be nice to cover as well.
Current implementation:
Production (how it should be):
src/pages-conditional/wallets.tsx
Outdated
| @@ -19,6 +19,7 @@ import { | |||
| Divider, | |||
| GrayContainer, | |||
| Page, | |||
| RightColumn, | |||
| StyledCard, | |||
| TwoColumnContent, | |||
| } from "../components/SharedStyledComponents" | |||
There was a problem hiding this comment.
As part of this migration, we deprecated the components living on SharedStyledComponents. We need to replace them using Chakra components as well.
There was a problem hiding this comment.
so I should refactor SharedStyledComponents first?
There was a problem hiding this comment.
No, you need to:
- remove that dependency
- replace all previous imported components like
TwoColumnContent,GrayContainer, etc. with Chakra components
You can take a look at other PRs and see how it was done. For example, #9524.
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team. GitPOAP: 2023 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Description
Migrate
wallets.tsxpage from emotion to ChakraRelated Issue
#9353