Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rust Developer Docs #367

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Add Rust Developer Docs #367

merged 1 commit into from
Nov 11, 2019

Conversation

Man-Jain
Copy link
Contributor

Programming-Language Specific Pages: Rust

Description

Added language-specific page for Rust following https://ethereum.org/python/ page as a template

Related Issue

Resolves #266

Screenshots (if appropriate):

Checklist:

  • I have read the contributing guidelines in the project README.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Man-Jain for your contribution!

I've already merged #361, which was the first PR to solve this issue. Since your PR has valuable additions on top of #361, we'd still like to incorporate your contributions & reward you for the bounty. Please rebase off the current dev branch & incorporate your content into the existing Rust page (docs/rust/index.md). Please be sure to delete any duplicate information / link references.

Thanks again!

@Man-Jain
Copy link
Contributor Author

Thank you @Man-Jain for your contribution!

I've already merged #361, which was the first PR to solve this issue. Since your PR has valuable additions on top of #361, we'd still like to incorporate your contributions & reward you for the bounty. Please rebase off the current dev branch & incorporate your content into the existing Rust page (docs/rust/index.md). Please be sure to delete any duplicate information / link references.

Thanks again!

Thanks @samajammin I have done the changes as you requested. Please consider them and give any feedbacks

Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates! I hope you continue to contribute & curate this page 😄

@samajammin samajammin merged commit ae2eedc into ethereum:dev Nov 11, 2019
@Man-Jain
Copy link
Contributor Author

Thanks for making these updates! I hope you continue to contribute & curate this page

Yes I will definitely.

@samajammin samajammin mentioned this pull request Nov 11, 2019
4 tasks
@samajammin
Copy link
Member

@all-contributors please add @Man-Jain for content

@allcontributors
Copy link
Contributor

@samajammin

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token } in JSON at position 5123

@samajammin
Copy link
Member

@all-contributors please add @Man-Jain for content

@allcontributors
Copy link
Contributor

@samajammin

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token } in JSON at position 5381

@samajammin
Copy link
Member

@all-contributors please add @Man-Jain for content

@allcontributors
Copy link
Contributor

@samajammin

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token } in JSON at position 5381

@samajammin
Copy link
Member

@all-contributors please add @Man-Jain for content

@allcontributors
Copy link
Contributor

@samajammin

I've put up a pull request to add @Man-Jain! 🎉

@samajammin
Copy link
Member

4th times a charm 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Programming-Language Specific Pages: Rust
2 participants