Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added language specific page for Golang [resolves #265] #366

Merged
merged 2 commits into from
Nov 11, 2019
Merged

Added language specific page for Golang [resolves #265] #366

merged 2 commits into from
Nov 11, 2019

Conversation

Abhimanyu121
Copy link
Contributor

Programming-Language Specific Pages: Golang

Added language-specific page for Golangfollowing https://ethereum.org/python/ page as a template

Related Issue

Resolves #265

Screenshots (if appropriate):

Checklist:

  • I have read the contributing guidelines in the project README.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@Abhimanyu121 Abhimanyu121 changed the title Added language specific page for Golan [resolves #265] Added language specific page for Golang [resolves #265] Oct 30, 2019
samajammin
samajammin suggested changes Nov 10, 2019
View reviewed changes
Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Abhimanyu121 for this contribution!

I've already merged #365, which was the first PR to solve this issue. Since your PR has valuable additions on top of #365, we'd still like to incorporate your contributions & reward you for the bounty. Please rebase off the current dev branch & incorporate your content into the existing Go page (docs/golang/index.md). Please be sure to delete any duplicate information / link references.

Thanks again & let me know if you have questions!

docs/golang/index.md Outdated


## Intermediate articles
- [Official geth Documentation](https://nethereum.readthedocs.io/en/latest/ethereum-and-clients/geth/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your link is to the nethereum doucmentation - I believe this is the official Geth documentation: https://geth.ethereum.org/docs/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change it.
Thank you

@Abhimanyu121
Copy link
Contributor Author

Thank you, I will rebase it.

@Abhimanyu121
Copy link
Contributor Author

@samajammin Thank you for your response, I have pushed the updated doc, can you please review it.

samajammin
samajammin approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! I hope you continue to contribute & curate this page 😄

@samajammin samajammin merged commit d2d1db9 into ethereum:dev Nov 11, 2019
@samajammin
Copy link
Member

@all-contributors please add @Abhimanyu121 for content

@allcontributors allcontributors bot mentioned this pull request Nov 11, 2019
Merged
@allcontributors
Copy link
Contributor

@samajammin

I've put up a pull request to add @Abhimanyu121! 🎉

@Abhimanyu121
Copy link
Contributor Author

Thanks for the update! I hope you continue to contribute & curate this page

Yes I would love to.
Thank you 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samajammin samajammin samajammin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Programming-Language Specific Pages: Golang
2 participants
@Abhimanyu121 @samajammin