refactor: explode ui/swiper into compossible parts #13931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrapping Swiper with SwiperContainer
in lieu of ui/swiper
migrates global.css styling into component
wackerow
requested review from
corwintines,
pettinarip and
minimalsm
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pettinarip
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
@wackerow this is a great refactor. Thanks for doing it. Liked that we have the styles closer to the components.
Left IMO a comment with an improvement, feel free to disagree and merge.
SwiperSlide imported from library and exported unchanged for convenience
Swiper React manipulates DOM limiting ability to allow Swiper elements to sit in-flow with the custom placement of a SwiperNavigation component (this component will be forced to the end of a `swiper-wrapper` element. Known limitation of Swiper React that this wrapper cannot be manipulated with `wrapperClass`. Alternatively, navigationPlacement variants added to at least enable positioning at bottom and top (default bottom)
pettinarip
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
absolutepositioning, with responsive width