Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadcn migration - Breadcrumbs #13854

Merged
merged 8 commits into from
Sep 23, 2024

Conversation

saurabhburade
Copy link
Contributor

Description

Migrate Breadcrumbs to tailwind.

Related Issue

Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit f2b38a7
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66f1634824d7f7000820a2d2
😎 Deploy Preview https://deploy-preview-13854--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 44 (🔴 down 2 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@saurabhburade saurabhburade marked this pull request as ready for review September 12, 2024 11:45
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saurabhburade thanks for this PR!

Visually it is correct but I think we are missing some semantic value from the previous version. We are missing the ordered list and items that gave the hierarchical order of the links.

For this reason, and because the shadcn component will also add a few more features, I think it is better to install the Breadcrumb component in our /components/ui folder using the cli or copying the files yourself. Once we have that we can use these components in our custom Breadcrumbs component to have the correct structure and recommended semantics.

<Breadcrumb>
  <BreadcrumbList>
    <BreadcrumbItem>
      <BreadcrumbLink href="/">Home</BreadcrumbLink>
    </BreadcrumbItem>
    <BreadcrumbSeparator />
    <BreadcrumbItem>
      <BreadcrumbLink href="/components">Components</BreadcrumbLink>
    </BreadcrumbItem>
    <BreadcrumbSeparator />
    <BreadcrumbItem>
      <BreadcrumbPage>Breadcrumb</BreadcrumbPage>
    </BreadcrumbItem>
  </BreadcrumbList>
</Breadcrumb>

Edit: aria pattern for breadcrumbs https://www.w3.org/WAI/ARIA/apg/patterns/breadcrumb/examples/breadcrumb/

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saurabhburade great! just pushed a commit to use the Next link component instead of the native one to get better i18n support for each link.

Approving, thanks for the PR!

@pettinarip pettinarip merged commit affaf28 into ethereum:dev Sep 23, 2024
8 of 9 checks passed
This was referenced Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants