-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shadcn migration - Breadcrumbs #13854
Shadcn migration - Breadcrumbs #13854
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saurabhburade thanks for this PR!
Visually it is correct but I think we are missing some semantic value from the previous version. We are missing the ordered list and items that gave the hierarchical order of the links.
For this reason, and because the shadcn component will also add a few more features, I think it is better to install the Breadcrumb component in our /components/ui
folder using the cli or copying the files yourself. Once we have that we can use these components in our custom Breadcrumbs
component to have the correct structure and recommended semantics.
<Breadcrumb>
<BreadcrumbList>
<BreadcrumbItem>
<BreadcrumbLink href="/">Home</BreadcrumbLink>
</BreadcrumbItem>
<BreadcrumbSeparator />
<BreadcrumbItem>
<BreadcrumbLink href="/components">Components</BreadcrumbLink>
</BreadcrumbItem>
<BreadcrumbSeparator />
<BreadcrumbItem>
<BreadcrumbPage>Breadcrumb</BreadcrumbPage>
</BreadcrumbItem>
</BreadcrumbList>
</Breadcrumb>
Edit: aria pattern for breadcrumbs https://www.w3.org/WAI/ARIA/apg/patterns/breadcrumb/examples/breadcrumb/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saurabhburade great! just pushed a commit to use the Next link component instead of the native one to get better i18n support for each link.
Approving, thanks for the PR!
Description
Migrate Breadcrumbs to tailwind.
Related Issue