Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create story for AssetDownload component #13045

Open
2 tasks
Tracked by #13043
corwintines opened this issue May 27, 2024 · 8 comments
Open
2 tasks
Tracked by #13043

Create story for AssetDownload component #13045

corwintines opened this issue May 27, 2024 · 8 comments
Labels
feature ✨ This is enhancing something existing or creating something new good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help Status: Stale This issue is stale because it has been open 30 days with no activity.
Milestone
Implementation of...

Comments

@corwintines
Copy link
Member

corwintines commented May 27, 2024 •
edited
Loading

Create story tests for AssetDownload component

Prerequisite

To get yourself up to speed on how we use storybook on ethereum.org, learn more here

What to do

  • Create story file /src/components/AssetDownload/AssetDownload.stories.tsx
  • Write story testing render of the AssetDownload component in context of use.

Note: When testing the AssetDownload, make sure to include stories that test both the ArtistDownloadImage component, and the ArtistDownloadArtist component. You can get context of how this component is used on the assets page
@corwintines corwintines mentioned this issue May 27, 2024
Open
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label May 27, 2024
@corwintines corwintines changed the title AssetDownload (Make sure this tests AssetDownloadArtist and AssetDownloadImage, expand in issue) [WIP] AssetDownload (Make sure this tests AssetDownloadArtist and AssetDownloadImage, expand in issue) May 27, 2024
@corwintines corwintines changed the title [WIP] AssetDownload (Make sure this tests AssetDownloadArtist and AssetDownloadImage, expand in issue) Create story for AssetDownload component May 28, 2024
@wackerow wackerow added feature ✨ This is enhancing something existing or creating something new good first issue Good item to try if you're new to contributing dev required This requires developer resources help wanted Extra attention is needed or someone is needed to help and removed needs triage 📥 This issue needs triaged before being worked on dev required This requires developer resources labels Jun 6, 2024
@wackerow wackerow added this to the 13043 milestone Jun 7, 2024
@wackerow wackerow added good first issue Good item to try if you're new to contributing and removed good first issue Good item to try if you're new to contributing labels Jun 13, 2024
@zeesh49
Copy link

zeesh49 commented Jun 20, 2024

hi, id like to work on this issue.

@corwintines
Copy link
Member Author

@zeesh49 great, I will flush this issue out and then feel free to get started :)

@zeesh49
Copy link

zeesh49 commented Jun 21, 2024

@corwintines I was removed from the discord server. may I know why?

@corwintines
Copy link
Member Author

Im not sure, I will ask. But, you should be able to join again @zeesh49. Sorry about that.

@zeesh49
Copy link

zeesh49 commented Jun 21, 2024

i did, but was removed again, then I messaged...i had no other medium except messaging here... @corwintines

@corwintines
Copy link
Member Author

This is open again, @zeesh49 messaged me on Discord to let me know.

@Spoorthy1423
Copy link

I would like to work on this issue @corwintines , please assign me this issue

@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature ✨ This is enhancing something existing or creating something new good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help Status: Stale This issue is stale because it has been open 30 days with no activity.
Projects
None yet
Milestone
Implementation of visual testing epic...
Development

No branches or pull requests
4 participants
@zeesh49 @corwintines @wackerow @Spoorthy1423