-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of visual testing epic #13043
Comments
For me it does not matter on which component I will work. I simply want to help. |
@corwintines noting here that I have #12960 up for |
Started attaching the sub-task Issues as "milestones" for this epic (13043) to help track |
Hey @corwintines could you assign me the |
@pettinarip created an issue and assigned. Will update description over there. |
Hi @corwintines , I'll like to be assigned the MergeInfoGraphic story. Thanks |
Hey, would love to help out with this, happy to start working on Form components (e.g. Buttons, Inputs, Checkbox,..) one by one. |
Hey @tomasgrusz ! Those components already have stories. They are shown as checked and only here for the organization of the list :) |
My mistake @TylerAPfledderer. In that case, I'm happy to pick up any of the remaining Atom components so that we can have all of them done. |
@tomasgrusz I pinged you in #13067 just now. If you are open for it, will assign :) |
@wackerow I'll like to be assigned the TranslationChartImage story. Please help create an issue for it and assign it to me |
@wackerow @corwintines I'll like to work on the CallToContribute component under Molecules. |
Creating those issues now for you @Baystef. Thank you for your patience and taking those on! |
@corwintines Please assign |
@corwintines I would like to work on BannerNotification pls assign |
Will create the issue for you now @prxjwal |
Hello |
This issue is stale because it has been open 30 days with no activity. |
Hi! I'm interested in working on this issue. I'd like to implement the Storybook component for BannerNotification. |
This is part of our Testing epic from our Q2 roadmap.
Description
We have implemented support for storybook to do testing on ethereum.org. We would like to be able to catch visual regressions before they reach production, helping us build confidence so that we can improve stability of ethereum.org through a testing suite. The first phase of this will be implementing visual storybook tests on our suite of components.
Below is the list of components in the ethereum.org repo, broken down by Atomic design.
How to contribute
If you’d like to help with adding stories for components, please follow these steps:
Components
Atoms
In Atomic Design, as in chemistry, atoms are the basic elements that help inform everything. In the world of web applications, atoms are the foundational elements, such as HTML tags, fonts, animations, and color palettes. Web design “atoms” can also be less concrete. Examples include buttons or forms.
Typeography
Media & icons - All visual references used in ethereum.org
Forms - Base html components used in forms
Molecules
Molecules are the next-largest building block. Created by the joining of different atomic elements, molecules are complex by nature. Because they’re the product of various atoms, though, it’s possible to break them down, conceptually, into UI elements that are easier to digest. Examples of web design molecules include the things that become the backbone of the larger design system, such as form labels or input field.
Navigation - components used to navigate to other pages. Inner or external to ethereum.org.
Display content - components used to show data/information primary
Disclosure content - components used to hide and show content useing interactive functions
Overlay content - components used on top from the main page
Action feedback - components used to show feedback of a user action
Organisms
Atoms combine to form molecules, and groups of molecules form organisms. In the world of Atomic Design, organisms are the UI elements that shape both the appearance and functionality of a website. They’re also the elements that start to impact user interface. The way a developer arranges molecules informs the site experience and the complexity of the finished product. Examples of organisms include logos, search fields, and main navigation which together may form a header organism.
Tasks
Snippets - composed components has use cases or references to display the same type of data
Templates
At this phase of the Atomic Design process, we start to break with the chemistry analogy and shift back into the lexicon of front-end development, as a whole. Templates, then, are “organisms” strung together at the page-level or beyond. Templates, online atoms, organisms, and molecules, are highly concrete. They provide a fixed context for the more abstract pieces to fit and are responsible for pulling the site together into something resembling its final form. An HTML wireframe is an excellent example of a template.
Templates - base pages to be used in creation of new content. They incorporate all of the components mandatory for the page
Pages
Pages, finally, are the final element of Atomic Design. According to Frost himself, pages are the specific instances of templates. Pages are the most tangible element of all and are the places users spend most of their time. They’re also one of the most essential phases of the Atomic Design process since the final iteration of pages is where developers get to see whether the entire design system is effective or not. In short, the final appearance of the pages dictates whether the product design is ready to launch, or whether the developer needs to loop back and make changes to earlier UI design elements.
Special cases - Pages that are unique and require custom made components
Pages - List of pages with final content to showcase and inspire
How to contribute
If you’d like to help with adding stories for components, please follow these steps:
The text was updated successfully, but these errors were encountered: