Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add towncrier #221

Merged
merged 4 commits into from
Nov 12, 2021
Merged

Add towncrier #221

merged 4 commits into from
Nov 12, 2021

Conversation

kclowes
Copy link
Contributor

@kclowes kclowes commented Nov 10, 2021

What was wrong?

We kept getting merge conflicts with the CHANGELOG. This PR should prevent that.

How was it fixed?

Configured towncrier, and set up CI to make sure the newsfragment file formats are correct.

To-Do:

  • Add current fragments to this PR

Cute Animal Picture

Cute animal picture

@kclowes kclowes changed the title [WIP] Add towncrier Add towncrier Nov 11, 2021
@kclowes kclowes force-pushed the add-towncrier branch 3 times, most recently from cbfd7ae to c1e3404 Compare November 11, 2021 18:26
@kclowes kclowes requested a review from fselmo November 11, 2021 18:27
Copy link
Contributor

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor cosmetic changes to title / versioning mentioned via Discord but LGTM 🚀

Great addition, thank you for this 🙏

@kclowes
Copy link
Contributor Author

kclowes commented Nov 12, 2021

np! Changed the title format, but had to drop the version down because it prints out two titles if you customize the title_format (we saw this issue in web3 as well) 🌈 . Looks like the double title issue is tracked here fixes it, but looks pretty stale 🤷

@kclowes kclowes merged commit 19ee9fa into ethereum:master Nov 12, 2021
@kclowes kclowes deleted the add-towncrier branch November 12, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants