Use ValidationError from eth_utils #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a ValidationError defined both here and there makes no sense and forces callsites to catch them both in some situations.
gsalgado
force-pushed
the
eth-utils-validationerror
branch
from
c99d8db to
00e27eb
Compare
|
This causes breakages in libraries ( I missed that it was a breaking change when scanning the included PRs since the last release. What would have helped me when doing the release is if this PR either:
|
|
I'm contemplating doing another patch release v0.3.3 that takes route 2 above |
pacrob
pushed a commit
to pacrob/eth-keys
that referenced
this pull request
Dec 20, 2023
Upgrade isort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a ValidationError defined both here and there makes no sense
and forces callsites to catch them both in some situations.