Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid generating empty transactions in tests #3884

Merged
merged 3 commits into from
Oct 22, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/core/pyspec/eth2spec/test/helpers/execution_payload.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def compute_trie_root_from_indexed_data(data):
t = HexaryTrie(db={})
for i, obj in enumerate(data):
k = encode(i, big_endian_int)
t.set(k, obj)
t.set(k, obj) # Implicitly skipped if `obj == b''` (invalid RLP)
return t.root_hash


Expand Down Expand Up @@ -353,4 +353,4 @@ def build_state_with_execution_payload_header(spec, state, execution_payload_hea


def get_random_tx(rng):
return get_random_bytes_list(rng, rng.randint(0, 1000))
return get_random_bytes_list(rng, rng.randint(1, 1000))