Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-7594-Polynomial-Commitments: Have a Section listing Public Methods #3795

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

b-wagn
Copy link
Contributor

@b-wagn b-wagn commented Jun 11, 2024

This PR introduces a section listing the public methods here.

Having such a section makes it easier for implementors and readers to identify the public methods.

Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I agree, this will make it easier to find public methods.

@jtraglia jtraglia added the EIP-7594 PeerDAS label Jun 11, 2024
@asn-d6
Copy link
Contributor

asn-d6 commented Jun 11, 2024

Thanks for the PR. Can you perhaps adapt it to include the changes introduced by #3788?

@b-wagn
Copy link
Contributor Author

b-wagn commented Jun 11, 2024

Thanks for the PR. Can you perhaps adapt it to include the changes introduced by #3788?

Sure, I will do that!

@b-wagn b-wagn force-pushed the 7594-poly-com-public-methods branch from 28fc32d to 288f0fb Compare June 11, 2024 12:16
Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@jtraglia jtraglia merged commit c5e9c3c into ethereum:dev Jun 11, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EIP-7594 PeerDAS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants