-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Capella fork version for BLSToExecution #3176
Conversation
I would apply the rule to use the gossip topic's fork version for BLSToExecution topics, even if it's not standard across all topics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with this but am not too worried about the UX issue if we don't patch. That said, if engineers are comfortable with this, it will ensure we don't get a bunch of dropped messages
specs/capella/p2p-interface.md
Outdated
@@ -59,11 +59,16 @@ See Capella [state transition document](./beacon-chain.md#beaconblockbody) for f | |||
|
|||
This topic is used to propagate signed bls to execution change messages to be included in future blocks. | |||
|
|||
Let `head_state` be a post state of the head of canonical chain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the chain or including any empty transitions to get to the current slot wrt wall time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I think we don't need the whole state in the definition of this change. I'll switch to system_clock_epoch
(Thought this name for the variable would be less ambiguous than current_epoch
)
I am in favour of this approach over the partial patch in #3135. I'm also open to the full cleanup of gossip topics, but think we could add that in a future fork to avoid delaying Capella. It doesn't seem like there would be any issue in spec or impl, but the devil is in the details and it would take time from the spec side and every team to roll it out. |
Co-authored-by: Michael Sproul <[email protected]>
Per the fork version validation, another solution is making |
Closing in favour of #3206 |
A stopgap fix for BLSToExecution gossip validation:
This fix only make sense if we can't afford a general fix of gossip messages validation because of additional engineering complexity. The general fix would be to always use a fork version from a gossip topic to compute signing domain across all topics.