Manually trigger LightClientStore force updates
#2947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces `process_slot_for_light_client_store` which force updates the `LightClientStore` automatically based on `finalized_header` age with `try_light_client_store_force_update` which may be manually called based on use case dependent heuristics if light client sync appears stuck. Not all use cases share the same risk profile.
hwwhww
reviewed
Jul 21, 2022
| apply_light_client_update(store, store.best_valid_update) | ||
| store.best_valid_update = None | ||
| ``` | ||
| - `try_light_client_store_force_update` MAY be called based on use case dependent heuristics if light client sync appears stuck. |
There was a problem hiding this comment.
it seems a big change to light client behavior.
There was a problem hiding this comment.
Previous behaviour can be simulated by calling this on every slot, same as before. But new behaviour allows for use cases such as historic data sync where it is not appropriate to force-apply every single update just because it is historic.
There was a problem hiding this comment.
@etan-status I see. So it is backward compatible. 👍
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
process_slot_for_light_client_storewhich force updates theLightClientStoreautomatically based onfinalized_headerage withtry_light_client_store_force_updatewhich may be manually called basedon use case dependent heuristics if light client sync appears stuck.
Not all use cases share the same risk profile.