Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify that eth1 block follow distance for genesis #1834

Merged
merged 2 commits into from
May 20, 2020
Merged

clarify that eth1 block follow distance for genesis #1834

merged 2 commits into from
May 20, 2020

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented May 20, 2020

addresses #1832

@djrtwo
Copy link
Contributor Author

djrtwo commented May 20, 2020

cc: @q9f @paulhauner @nisdas

@djrtwo djrtwo requested a review from protolambda May 20, 2020 16:46
protolambda
protolambda reviewed May 20, 2020
View reviewed changes
specs/phase0/beacon-chain.md Outdated Show resolved Hide resolved
specs/phase0/beacon-chain.md Show resolved Hide resolved
@protolambda
Copy link
Contributor

protolambda commented May 20, 2020 •
edited
Loading

Edit: wrong PR, sorry. Ignore this.

protolambda
protolambda approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djrtwo djrtwo merged commit a6d4566 into dev May 20, 2020
@djrtwo djrtwo deleted the clarify-genesis-safety branch May 20, 2020 18:44
@djrtwo djrtwo mentioned this pull request May 20, 2020
Closed
@terencechain terencechain mentioned this pull request May 20, 2020
Closed
25 tasks
@nisdas nisdas mentioned this pull request May 21, 2020
Merged
@q9f
Copy link
Contributor

q9f commented May 22, 2020

Thanks

@ColinSchwarz ColinSchwarz mentioned this pull request May 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protolambda protolambda protolambda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djrtwo @protolambda @q9f