Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor refactor aggregation strategy #1484

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Minor refactor aggregation strategy #1484

merged 1 commit into from
Nov 18, 2019

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Nov 18, 2019 •
edited
Loading

  1. Update AggregateAndProof and
    1. Reorder the fields to fit the container name
    2. Rename AggregateAndProof.index: ValidatorIndex to AggregateAndProof.aggregator_index: ValidatorIndex
      • Rationale: we have similar naming style like
        ProposerSlashing.proposer_index or VoluntaryExit.validator_index
  2. Rename slot_signature to get_slot_signature.

@hwwhww
Update AggregateAndProof and rename slot_signature to `get_slot_s…
8fed220 
…ignature`

1. Reorder the fields to fit the container name
2. Rename `AggregateAndProof.index: ValidatorIndex` to `AggregateAndProof.aggregator_index: ValidatorIndex`
    - Since we also have similar naming style like
`ProposerSlashing.proposer_index` or `VoluntaryExit.validator_index`
@hwwhww hwwhww added scope:v-guide Validator guide general:presentation Presentation (as opposed to content) scope:networking labels Nov 18, 2019
@hwwhww hwwhww requested a review from djrtwo November 18, 2019 13:51
djrtwo
djrtwo approved these changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@djrtwo djrtwo merged commit 67322a4 into v09x Nov 18, 2019
@djrtwo djrtwo deleted the refactor_aggregation_strategy branch November 18, 2019 20:24
@terencechain terencechain mentioned this pull request Nov 24, 2019
Closed
6 tasks
@ralexstokes ralexstokes mentioned this pull request Nov 27, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
general:presentation Presentation (as opposed to content) scope:networking scope:v-guide Validator guide
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwwhww @djrtwo