fix BLS tests name length #1405
Merged
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to limitations on some filesystems (e.g. encryptfs has a 120 file name char limit), some tests could not be loaded due to their name length. This changes the BLS tests with the long names to use small checksums to uniquely identify the test. Other tests stay as-is, as they are < 100 chars, which I will try to maintain as limit in the future.
I'm not sure when we should be releasing a new spec tests version, as we are in the middle of interop-lockin. The tests can at least be ran on normal file-systems, so I do not think it is too urgent anyway.
cc @prestonvanloon