Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validator spec #18
Add validator spec #18
Changes from 3 commits
5b28094
d398503
a38375d
02090b4
08e44e6
f5dd8e1
2ab456f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about including fallback to a local build process to the steps outlined above? In this case the place from which the fallback becomes dangerous (due to slashing) could be clearly defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would obscure the flow outlined above but I'm open to it if many think it is clearer.
As far as I know most clients have some version of this implemented already and they have two distinct code paths so it maps directly to say "run these two tasks, race them against a deadline"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with current description as long as implementers clearly understand the last moment where they can safely sign off on a payload that is built locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe it could be clearer if we refer
BUILDER_PROPOSAL_DELAY_TOLERANCE
specifically to bid providing.something like
... will give the builders a duration of
BUILDER_PROPOSAL_DELAY_TOLERANCE
to provide aSignedBuilderBid
before the external builder is considered to have hit the deadline and the externalor also rename it to
BUILDER_BID_PROPOSAL_DELAY_TOLERANCE
?this way it is clear the assumption that the fallback is no more an option once validator sign a blind block made with the bid.