Add EIP-7805 (FOCIL) endpoints #490
Conversation
Co-authored-by: Nico Flaig <[email protected]>
types/focil/inclusion_list.yaml
Outdated
| Focil: | ||
| InclusionList: |
There was a problem hiding this comment.
we'll want a fork name rather than a EIP name for the api, but it's probably premature to know that I guess...
There was a problem hiding this comment.
I think for now we should keep it as EIP name (or number) but it would be good if we can merge new endpoints before those are officially part of a hard fork. I added a new tag "Draft" here to separate those in the api explorer, but maybe even a EIP specific tag would make sense.
There was a problem hiding this comment.
In teku i just use Experimental tag but draft also works, that'd be fine...
There was a problem hiding this comment.
That's what I was using but it had a different purpose previously when it was used for the rewards apis. I think either one works, if we do this for more EIPs it might even be good to use a separate tag for each. This would allow to disable spec tests based on tag
There was a problem hiding this comment.
its been super problematic merging with feature flags sometimes, that's my hesitation.
There was a problem hiding this comment.
Yeah we probably won't be merging this any time soon since the CL spec isn't even merged yet but it would be nice if we can come up with an approach to allow merging this before it's confirmed as part of a hard fork.
I pushed a few changes group files / types under EIP specific namespace and used the EIP as tag as well, this would allow us to have more than one EIP in "Draft" stage and be part of the api explorer.
No description provided.