-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update attestation APIs to support EIP-7549 #448
Conversation
What about attestation event, should it be part of this PR? beacon-APIs/apis/eventstream/index.yaml Lines 64 to 68 in fb718b6
|
I considered the event stream events out of the scope of this PR. Might be addressed in a separate PR imo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't reviewed everything in detail but general approach looks good to me, let's get some feedback from others, especially in regard to having to bump everything to v2 or not
Yep I agree with new version for interfaces given they're a new required field (breaking) and headers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to resolve conflicts since we merged #447
Following the Electra containers updates:
/block
and/pool
attestation GET APIs to handle the new Electra attestationsElectra.Attestation
schemaAttestationData
schema used by bothAttestation
andElectra.Attestation
IndexedAttestation
schemaPartially fixes #445
Related to #447