Implement EIP1380 (call-to-self) in aleth-interpreter

[halfalicious]

No tests since @gumb0 mentioned that there's no way to measure gas cost in tests which use aleth-interpreter.

[halfalicious]

Still need to create tests

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@872f2ef). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #5753   +/-   ##
=========================================
  Coverage          ?   64.03%           
=========================================
  Files             ?      359           
  Lines             ?    30774           
  Branches          ?     3416           
=========================================
  Hits              ?    19706           
  Misses            ?     9844           
  Partials          ?     1224

[halfalicious]

Rebased

[chfast]

You need to have the cheap m_rev >= EVMC_BERLIN check first.

[halfalicious]

@chfast Ah good point, comparing addresses is expensive since you're comparing 32 byte boost multiprecision values which are also first converted from big endian, instead of an EVMC_REVISION which is an enum (4 bytes).

[halfalicious]

@chfast I also removed the fromEvmc calls here:

aleth/libaleth-interpreter/VMCalls.cpp

Lines 197 to 198 in d843b9b

	// Check for call-to-self (eip1380) and adjust gas accordingly
	if (m_rev >= EVMC_BERLIN && m_message->destination == destination)

I think that's okay since these are both evmc_address objects so they can be compared (well technically destination is evmc::address which is a subclass of evmc_address but I don't think the subclass implements anything which would affect the comparison).

[gumb0]

@halfalicious I removed the assignment to m_runGas from the metrics table, because it's actually already done for each opcode in fetchInstruction()

[halfalicious]

@halfalicious I removed the assignment to m_runGas from the metrics table, because it's actually already done for each opcode in fetchInstruction()

@gumb0 Ah I see, it’s done here:

aleth/libaleth-interpreter/VM.cpp

Line 220 in 06dad45

m_runGas = metric.gas_cost;

Thanks for the heads up!