This repository was archived by the owner on Oct 28, 2021. It is now read-only.
Use metrics of the requested revision in aleth-interpreter #5679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
force-pushed
the
optimizer-undefined
branch
from
75c34b4 to
f46cec0
Compare
gumb0
commented
Jul 17, 2019
gumb0
force-pushed
the
optimizer-undefined
branch
8 times, most recently
from
a561b66 to
7d7dea0
Compare
Codecov Report
@@ Coverage Diff @@
## master #5679 +/- ##
==========================================
+ Coverage 62.98% 62.99% +<.01%
==========================================
Files 350 350
Lines 29993 29994 +1
Branches 3361 3362 +1
==========================================
+ Hits 18891 18894 +3
+ Misses 9884 9883 -1
+ Partials 1218 1217 -1 |
gumb0
force-pushed
the
optimizer-undefined
branch
5 times, most recently
from
1dbf677 to
5841d3a
Compare
|
Now GCC issue disappeared, so I think this is ready for review. |
chfast
reviewed
Jul 23, 2019
chfast
approved these changes
Jul 23, 2019
gumb0
force-pushed
the
optimizer-undefined
branch
from
a1212a0 to
6b5c3e9
Compare
|
Rebased. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problem described in #5653 (comment), makes this change in test not needed ethereum/evmone#91
I came up here with (maybe a bit tricky) way to lazy-initialize metrics array for needed revision usingSettled upon a simpler non-lazy approach.std::once_flag. But I think it looks not so complicated.