split BlockchainTests into Valid and Invalid #5648
Conversation
|
We should first fix failing tests where we disagree with geth, I try to work on that in #5652 |
| @@ -1024,6 +1054,20 @@ class bcTestFixture { | |||
| } | |||
| }; | |||
|
|
|||
| class bcInvalidTestFixture | |||
There was a problem hiding this comment.
This class is almost identical to the one above, it looks like you could have a base class common for both to avoid code repetition. Just a suggestion.
There was a problem hiding this comment.
There is a plan for malicious block blockchain testsing, when the test tool will produce invlid block rlps and try to import.
Thats for the future. for now just separate tests with invalid blocks that we have.
winsvega
force-pushed
the
splitBlockchain
branch
from
3789600 to
8f7e7ac
Compare
Codecov Report
@@ Coverage Diff @@
## master #5648 +/- ##
==========================================
+ Coverage 63% 63.05% +0.05%
==========================================
Files 350 350
Lines 29915 29944 +29
Branches 3352 3353 +1
==========================================
+ Hits 18847 18882 +35
+ Misses 9850 9847 -3
+ Partials 1218 1215 -3 |
| @@ -60,6 +60,7 @@ class TestOutputHelper | |||
| TestOutputHelper() {} | |||
| void checkUnfinishedTestFolders(); // Checkup that all test folders are active during the test | |||
| // run | |||
| std::string detectFilterForMinusTArgument(); | |||
| @@ -95,95 +95,95 @@ BOOST_AUTO_TEST_CASE(basicGasPricer_RPC_API_Test_Frontier) | |||
| { | |||
| u256 _expectedAsk = 16056883295; | |||
| u256 _expectedBid = 1; | |||
| dev::test::executeGasPricerTest("RPC_API_Test_Frontier", 30.679, 15.0, "/BlockchainTests/bcGasPricerTest/RPC_API_Test.json", TransactionPriority::Medium, _expectedAsk, _expectedBid, eth::Network::FrontierTest); | |||
| dev::test::executeGasPricerTest("RPC_API_Test_Frontier", 30.679, 15.0, "/BlockchainTests/ValidBlocks/bcGasPricerTest/RPC_API_Test.json", TransactionPriority::Medium, _expectedAsk, _expectedBid, eth::Network::FrontierTest); | |||
There was a problem hiding this comment.
Would be better to get rid of repetition here, moving "/BlockchainTests/ValidBlocks/" to a constant
There was a problem hiding this comment.
or by moving it inside executeGasPricerTest function
split BlockchainTests into BlockchainTests/ValidBlocks and BlockchainTests/InvalidBlocks
move TransitionTests under BlockchainTests
ValidBlocks contain only tests with valid rlps
InvalidBlocks contain tests where some block rlp's are invalid and expect and exception upon import
Update test subfolder to this PR ethereum/tests#605