Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website: Intrinsic RevShare Token #284
Website: Intrinsic RevShare Token #284
Changes from 9 commits
aa49939
c22c524
022ee8c
a990eb5
d19f79b
a233719
420a266
72f4d1c
5752fd0
5c8f00c
468a22a
e417286
74a46f4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This paragraph sounds like it's creating requirements on implementations? For example, "the amount of ETH claimable [...] is
pR * amount / totalAmount
" seems like an instruction to implementers.If these are requirements, they'll need to be moved to the Specification section. The reasoning behind why that formula exists should remain in the Rationale section.
The idea is that the Specification section, taken alone, should be enough for someone to write a compliant implementation of this proposal. The other sections (Rationale included) are here for context and history purposes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have changed the wording to reflect that it is an example. Please review!