Update EIP-7702: consistent signature validity checks #8865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-update
File
|
| * `r`: unsigned 256-bit integer. | ||
| * `s`: unsigned 256-bit integer and value less or equal than `secp256k1n/2`, specified in [EIP-2](./eip-2.md). | ||
| * `r`: unsigned 256-bit integer and `0 < r < secp256k1n`. | ||
| * `s`: unsigned 256-bit integer and `0 < s <= secp256k1n/2`, specified in [EIP-2](./eip-2.md). |
There was a problem hiding this comment.
Suggested change
| * `s`: unsigned 256-bit integer and `0 < s <= secp256k1n/2`, specified in [EIP-2](./eip-2.md). | |
| * `r`: unsigned 256-bit integer and `0 < r < n`, where `n` is the order of the base point of secp256k1 as specified by [SEC 2:](http://www.secg.org/sec2-v2.pdf). | |
| * `s`: unsigned 256-bit integer and `0 < s <= n/2`, specified in [EIP-2](./eip-2.md). |
|
I'm planning to simplify the validity checks for 7702 in this PR, so I don't think it's necessary to make this change. |
somnathb1
pushed a commit
to erigontech/erigon
that referenced
this pull request
Sep 12, 2024
Check (in the txpool and in the main code) that an EIP-7702 transaction is [valid](https://eips.ethereum.org/EIPS/eip-7702#set-code-transaction), namely that: - `to != nil` - `len(authorization_list) != 0` - `authorization.chain_id` is `uint256` - `authorization.nonce` is `uint64` - `authorization.address` is `bytes20` - `authorization.y_parity == 0 || authorization.y_parity == 1` - `authorization.r` is `uint256` - `authorization.s` is `uint256` and `authorization.s <= secp256k1n/2` This PR doesn't implement ethereum/EIPs#8865 or ethereum/EIPs#8845
somnathb1
pushed a commit
to erigontech/erigon
that referenced
this pull request
Sep 12, 2024
Check (in the txpool and in the main code) that an EIP-7702 transaction is [valid](https://eips.ethereum.org/EIPS/eip-7702#set-code-transaction), namely that: - `to != nil` - `len(authorization_list) != 0` - `authorization.chain_id` is `uint256` - `authorization.nonce` is `uint64` - `authorization.address` is `bytes20` - `authorization.y_parity == 0 || authorization.y_parity == 1` - `authorization.r` is `uint256` - `authorization.s` is `uint256` and `authorization.s <= secp256k1n/2` This PR doesn't implement ethereum/EIPs#8865 or ethereum/EIPs#8845
|
Closing in favour of #8845 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently EIP-7702 mentions that the validity of
sis based on EIP-2 (s <= secp256k1n/2), but EIP-2 itself is a tweak of the pre-Homestead validity check (0 < r < secp256k1n,0 < s < secp256k1n). See ValidateSignatureValues in geth.