Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website: remove dependency on eips preamble entry #6799

Closed
wants to merge 7 commits into from

Conversation

Pandapip1
Copy link
Member

No description provided.

@Pandapip1 Pandapip1 marked this pull request as ready for review March 29, 2023 15:32
@Pandapip1 Pandapip1 requested a review from eth-bot as a code owner March 29, 2023 15:32
@@ -3,12 +3,13 @@
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
{% if page.layout == "eip" %}
{% assign eip = page.url | split: "eip-" | last | xml_escape %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may not be robust enough. What happens with files named like eip-an_extension_to_eip-1559.md? Similarly, what about assets/eip-1234/eip-20-diagram.png?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a file cannot exist. Only underscores are allowed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, interesting. Where's that enforced? This bot?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! The bot overrides any EIP value that the user provides.

@eth-bot
Copy link
Collaborator

eth-bot commented Mar 29, 2023

File _includes/head.html

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File _layouts/eip.html

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File rss/erc-last-call.xml

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File rss/erc.xml

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File rss/last-call.xml

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File rss/nonerc-last-call.xml

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

File rss/nonerc.xml

Requires 1 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Mar 29, 2023
@lightclient
Copy link
Member

As #6970 was closed, this is no longer relevant.

@lightclient lightclient closed this Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e-consensus Waiting on editor consensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants