-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-1: Remove eip
preamble entry
#6790
Conversation
File
|
eip
preamble entryeip
preamble entry
Where is the EIP number specified if not in the preamble? Is it in the filename? |
Yes. |
There is no need to remove the eip from the preamble. |
Actually, it makes eip-review-bot slightly simpler, and also removes redundant information. So my stance is 'there is no need to keep the eip in the preamble.' |
I'm generally in favour of single-sourcing information as much as possible, so in this case I'd lean towards removing @lightclient are there any scenarios where removing the header is problematic? |
It's a long standing piece of the preamble. I think it is a unique piece of the EIP process and I would be sad to see it go. I would rather increase the complexity of the bots to deal with it than remove it. However, it's not something I feel terribly strongly about. What I do feel strongly about is the constant change in the repository. Things like this are marginal improvements that will likely cause more confusion to authors than do good in the short term. I think it is time to start make changes at more spaced intervals and batching many of these changes together at once. |
Would you mind explaining what exactly you dislike about continuous improvement? How would batching changes address those concerns? |
The vast majority of contributors to this repository only do so occasionally. I am messaged frequently about "why is this like this now" and "when did this requirement get added / go away". If software is expected to batch breaking changes into major release, it should go doubly so for processes IMO. |
I don't think it significantly increases the technical complexity of the bots to include the EIP number in the preamble. We'd just need to figure out exactly how it should work. On the
Sound right? |
Nope, I think that the |
How about versioned processes? So that older EIPs can get "grandfathered" and use older formatting/rules? |
My position is against of removing EIP number in preamble in the content. Reason: the piece of information "number" is important enough to be replicated in the content and hence could be double checked, carried in publication, spread etc. |
Closing as there wasn't sufficient support in the EIPIP meeting. |
Nothing really depends on the EIP number being in the preamble anymore, so we can safely remove it.