Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-5507: Move to Last Call #6556

Merged
merged 4 commits into from
Apr 18, 2023
Merged

Update EIP-5507: Move to Last Call #6556

merged 4 commits into from
Apr 18, 2023

Conversation

Pandapip1
Copy link
Member

@Pandapip1 Pandapip1 commented Feb 23, 2023 •
edited by github-actions bot
Loading

No description provided.

@Pandapip1 Pandapip1 requested a review from eth-bot as a code owner February 23, 2023 20:12
@github-actions github-actions bot added c-status Changes a proposal's status t-erc labels Feb 23, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 23, 2023 •
edited
Loading

✅ All reviewers have approved.

SamWilsn
SamWilsn requested changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This proposal doesn't do a good enough job explaining why these interfaces need to be standardized in an EIP. As far as I can tell, any token that wants to offer a refund can do so, and the interface used doesn't need to be standardized.

@Pandapip1 Pandapip1 requested a review from SamWilsn February 23, 2023 22:42
@Pandapip1
Copy link
Member Author

Done. Updating this branch...

@Pandapip1
Copy link
Member Author

@eth-bot rerun

@eth-bot eth-bot added the e-review Waiting on editor to review label Feb 24, 2023
@poojaranjan poojaranjan mentioned this pull request Mar 7, 2023
Closed
25 tasks
@poojaranjan poojaranjan mentioned this pull request Apr 18, 2023
Closed
23 tasks
SamWilsn
SamWilsn reviewed Apr 18, 2023
View reviewed changes
EIPS/eip-5507.md Outdated Show resolved Hide resolved
SamWilsn
SamWilsn approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not sold that this is the best approach, but I don't think there's anything technically blocking this EIP from progressing.

@eth-bot eth-bot enabled auto-merge (squash) April 18, 2023 15:42
eth-bot
eth-bot approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

eth-bot
eth-bot approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit be7979a into master Apr 18, 2023
@eth-bot eth-bot deleted the Pandapip1-patch-4 branch April 18, 2023 15:48
@poojaranjan poojaranjan mentioned this pull request Apr 19, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eth-bot eth-bot eth-bot approved these changes

@SamWilsn SamWilsn SamWilsn approved these changes

Assignees
No one assigned
Labels
c-status Changes a proposal's status e-review Waiting on editor to review t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pandapip1 @eth-bot @SamWilsn