Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-5496: Change status to Last Call #5768

Closed
wants to merge 87 commits into from
Closed

Conversation

wnft
Copy link
Contributor

@wnft wnft commented Oct 8, 2022

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

xinbenlv and others added 19 commits November 16, 2022 00:31
* Init a EIP for Commit Interface

* Update file name

* Add content

* Update name

* Add mentioning of chainid

* Add discussion-to

* Function parameter

* Add abstract

* Add voting example.

* Update eip-5732.md

* Update EIP-5732 with move to Last Call

* Update wording

* U

* U

* U

* Update eip-5732.md

* Update EIPS/eip-5732.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5732.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5732.md

Co-authored-by: Pandapip1 <[email protected]>

* Update suggested by @mattstam

* Update eip-5732.md

* Update EIPS/eip-5732.md

Co-authored-by: Matt Stam <[email protected]>

* Update

* Add co-author

* update deadline

* Update format

* Update last-call deadline

* Fix format

* Add backwards compatibility

* Move the security note out from specs

* Fix typos

Co-authored-by: Pandapip1 <[email protected]>
Co-authored-by: Matt Stam <[email protected]>
* fix nit on the language of eip-1153

* fix linter errors

* last linter error
* Move EIP-5732 to Final

* Wording

* Update requires

* Tighten up grammar

* Fix list formatting

* Tighten security considerations

* Remove random sublist

Co-authored-by: Pandapip1 <[email protected]>
* MOD: eip-5489 to review

* Update EIPS/eip-5489.md

Co-authored-by: Sam Wilson <[email protected]>

* Update EIPS/eip-5489.md

Co-authored-by: xinbenlv <[email protected]>

* MOD: update introduction

* FIX: lint

* Update EIPS/eip-5489.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5489.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5489.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5489.md

Co-authored-by: Pandapip1 <[email protected]>

* FIX: lint

* DEL: hnft new URI schema

Co-authored-by: Sam Wilson <[email protected]>
Co-authored-by: xinbenlv <[email protected]>
Co-authored-by: Pandapip1 <[email protected]>
* chore: set to Review

* fix: lint

* fix: lint
)

* add Restrict Web3 Provider Object API Injection

* rename to EIP using PR number

* add required EIP 1193

* Update EIPS/eip-5593.md

Co-authored-by: xinbenlv <[email protected]>

* Update EIPS/eip-5593.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5593.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5593.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5593.md

Co-authored-by: Pandapip1 <[email protected]>

* Delete duplicate file

* Create W3 license

* Create Media Capture and Streams.pdf

* That failed

* add optional allow attribute usage for 3P iframes

* update normative restrictions for provider objects

* update test cases with better descriptions

* update link to normative definition of potentially trustworthy origin

* address subdomain test case

* update abstract and motivation for readability and to cite a specific attack

* modify normative statement about private tab usage

* rename EIP to better reference EIP-1193 terminology

* update links to use anchor links

* add @thypon as an author who contributed to intial review and implementation

* edit language to clarify when to inject ETH Provider

* update links to use markdown reference links

* update 3p suborigin iframe case to accurately reflect implementation

* remove optional test cases

* add privacy considerations section

* editorial update about configuring potentially trustworthy origins

* rename 3P to third-party

* change CAIP to EIP text

* remove external links

* add authors note about linking issue

* add links to Github PRs about reference implementations

* editorial updates

Co-authored-by: Sam Wilson <[email protected]>

* address dictator eipw bot's commands

* remove assets folder for EIP-5593

* Move privacy considerations to subheading of security considerations, and move author's note to subheading of abstract

* Oops, fix order

* Fix false positive

* remove reference implementation links

Co-authored-by: Pandapip1 <[email protected]>

Co-authored-by: xinbenlv <[email protected]>
Co-authored-by: Pandapip1 <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
* set lower target/max

* add throughput rationale
* remove optional

* some language cleanup
* Update eip-4519.md

* Update eip-4519.md
* Create eip-ens-as-holder

* Update eip-ens-as-holder

* Update eip-ens-as-holder

* Update eip-ens-as-holder

* Update eip-ens-as-holder

* Update eip-ens-as-holder

* Update eip-ens-as-holder

* Update EIPS/eip-ens-as-holder

Co-authored-by: Micah Zoltu <[email protected]>

* Update EIPS/eip-ens-as-holder

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-ens-as-holder

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-ens-as-holder

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-ens-as-holder

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-ens-as-holder

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-ens-as-holder

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-ens-as-holder

Co-authored-by: Pandapip1 <[email protected]>

* Update content

* Update content

* Update content

* Update content

* Add reference implementations and test cases

* Update spacing

* Fix spacing

* Change

* fix format

* Update lint

* Update wording

* Fix typos

Co-authored-by: Micah Zoltu <[email protected]>
Co-authored-by: Pandapip1 <[email protected]>
@github-actions github-actions bot added c-new Creates a brand new proposal c-update Modifies an existing proposal s-draft This EIP is a Draft s-final This EIP is Final s-review This EIP is in Review s-stagnant This EIP is Stagnant t-core t-interface t-networking labels Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal c-status Changes a proposal's status c-update Modifies an existing proposal s-draft This EIP is a Draft s-final This EIP is Final s-review This EIP is in Review s-stagnant This EIP is Stagnant t-core t-erc t-interface t-networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.