Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-5521: Add more descriptions #5563

Merged
merged 32 commits into from
Sep 1, 2022
Merged

Update EIP-5521: Add more descriptions #5563

merged 32 commits into from
Sep 1, 2022

Conversation

OniReimu
Copy link
Contributor

  1. Add a description of the collaboration with the eip-998
  2. Add customized attribute data fields for specific scenarios
  3. Remove 5006 from required as 5006 is merely a protocol to collaborate with rather than a compulsory basis, similar to the newly-added 998.

OniReimu and others added 27 commits August 22, 2022 13:48
@OniReimu
Create eip-referable-NFT.md
59bbdb4 
This standard proposes an extension to ERC-721 Non-Fungible Tokens (NFTs) to construct reference relationships among NFTs.
@OniReimu
Update eip-***.md
f6253d1
@OniReimu
Update eip-referableNFT.md
4cb5d13
@OniReimu
update eip name
c7bb8b8
@OniReimu
Update eip-0000.md
ce5750a
@OniReimu
Update eip-0000.md
26536e7
@OniReimu
Update eip-0000.md
9228835
@OniReimu
Update eip-0000.md
4bfe81e
@OniReimu
Update eip-0000.md
c3060a8
@OniReimu
Update eip-0000.md
38e3c28
@OniReimu
Update eip number
e9c4731 
Update eip number
@OniReimu @Pandapip1
Update EIPS/eip-5521.md
bf68206 
Co-authored-by: Pandapip1 <[email protected]>
@OniReimu @Pandapip1
Update EIPS/eip-5521.md
e7275a2 
Co-authored-by: Pandapip1 <[email protected]>
@OniReimu @Pandapip1
Update EIPS/eip-5521.md
e33b053 
Co-authored-by: Pandapip1 <[email protected]>
@OniReimu @Pandapip1
Update EIPS/eip-5521.md
9aa7f3d 
Co-authored-by: Pandapip1 <[email protected]>
@OniReimu @Pandapip1
Update EIPS/eip-5521.md
44fb0b8 
Co-authored-by: Pandapip1 <[email protected]>
@OniReimu @Pandapip1
Update EIPS/eip-5521.md
e34fe37 
Co-authored-by: Pandapip1 <[email protected]>
@OniReimu @Pandapip1
Update EIPS/eip-5521.md
32baeb1 
Co-authored-by: Pandapip1 <[email protected]>
@OniReimu @Pandapip1
Update EIPS/eip-5521.md
b81b3ea 
Co-authored-by: Pandapip1 <[email protected]>
@OniReimu @Pandapip1
Update EIPS/eip-5521.md
a6ee02f 
Co-authored-by: Pandapip1 <[email protected]>
@OniReimu @Pandapip1
Update EIPS/eip-5521.md
adb67d3 
Co-authored-by: Pandapip1 <[email protected]>
@OniReimu @Pandapip1
Update EIPS/eip-5521.md
5a1df32 
Co-authored-by: Pandapip1 <[email protected]>
@OniReimu @Pandapip1
Update EIPS/eip-5521.md
478c0fb 
Co-authored-by: Pandapip1 <[email protected]>
@OniReimu
Merge branch 'master' into master
bca965b
@OniReimu
Update eip-5521.md
26435d5
@OniReimu
Update eip-5521.md
726a11a
@OniReimu
Update eip-5521.md
5541afe
@OniReimu OniReimu requested a review from eth-bot as a code owner August 31, 2022 04:21
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft labels Aug 31, 2022
@github-actions github-actions bot added the t-erc label Aug 31, 2022
@eth-bot
Copy link
Collaborator

eth-bot commented Aug 31, 2022 •
edited
Loading

A critical exception has occurred:
Message: pr 5563 is already merged; quitting
(cc @alita-moore, @mryalamanchi)

xinbenlv
xinbenlv reviewed Aug 31, 2022
View reviewed changes
Copy link
Contributor

@xinbenlv xinbenlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OniReimu thanks for the PR
First of all, is it creating a new EIP or is a updating descriptions?

Pandapip1
Pandapip1 suggested changes Aug 31, 2022
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the merge conflicts

@github-actions github-actions bot removed c-new Creates a brand new proposal t-erc s-draft This EIP is a Draft labels Sep 1, 2022
@github-actions github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft t-erc labels Sep 1, 2022
@OniReimu
Copy link
Contributor Author

OniReimu commented Sep 1, 2022

Hello @xinbenlv , this is essentially an update for EIP-5521, not a new eip proposal.

@OniReimu OniReimu requested a review from Pandapip1 September 1, 2022 00:28
@OniReimu
Copy link
Contributor Author

OniReimu commented Sep 1, 2022

Conflicts fixed, thank you @ Pandapip1 :)

Pandapip1
Pandapip1 reviewed Sep 1, 2022
View reviewed changes
EIPS/eip-5521.md Outdated
@@ -2,13 +2,13 @@
eip: 5521
title: Referable NFT
description: An EIP-721 extension to construct reference relationships among NFTs
author: Saber Yu (@OniReimu), Qin Wang <[email protected]>, Shange Fu <[email protected]>, Shiping Chen <shiping.chen@data61.csiro.au>, Sherry Xu <[email protected]>, Jiangshan Yu <[email protected]>
author: Saber Yu (@OniReimu), Qin Wang <[email protected]>, Shange Fu <[email protected]>, Shiping Chen <shiping.chen@data61.csiso.au>, Sherry Xu <[email protected]>, Jiangshan Yu <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

csiso is a typo.

Pandapip1
Pandapip1 reviewed Sep 1, 2022
View reviewed changes
.gitignore Outdated
@@ -9,3 +9,4 @@ vendor

# Secrets
.vercel
.DS_Store
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this in a separate PR.

Copy link
Contributor Author

@OniReimu OniReimu Sep 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change removed

@eth-bot eth-bot enabled auto-merge (squash) September 1, 2022 01:01
@Ellajoke
Copy link

Ellajoke commented Sep 1, 2022

Approve

@OniReimu OniReimu requested a review from Pandapip1 September 1, 2022 01:05
@Pandapip1 Pandapip1 disabled auto-merge September 1, 2022 01:09
@Pandapip1 Pandapip1 merged commit bab9d3f into ethereum:master Sep 1, 2022
@Pandapip1
Copy link
Member

(FYI for any concerned editors: @eth-bot was passing, so I was able to merge it)

nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
@OniReimu @Pandapip1 @nachomazzara
Update EIP-5521: Add more descriptions (ethereum#5563)
46addc3 
* Create eip-referable-NFT.md

This standard proposes an extension to ERC-721 Non-Fungible Tokens (NFTs) to construct reference relationships among NFTs.

* Update eip-***.md

* Update eip-referableNFT.md

* update eip name

* Update eip-0000.md

* Update eip-0000.md

* Update eip-0000.md

* Update eip-0000.md

* Update eip-0000.md

* Update eip-0000.md

* Update eip number

Update eip number

* Update EIPS/eip-5521.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5521.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5521.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5521.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5521.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5521.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5521.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5521.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5521.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5521.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5521.md

Co-authored-by: Pandapip1 <[email protected]>

* Update EIPS/eip-5521.md

Co-authored-by: Pandapip1 <[email protected]>

* Update eip-5521.md

* Update eip-5521.md

* Update eip-5521.md

* Update eip-5521.md

* Update

* Update .gitignore

Co-authored-by: Pandapip1 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xinbenlv xinbenlv xinbenlv left review comments

@Pandapip1 Pandapip1 Pandapip1 approved these changes

@eth-bot eth-bot eth-bot approved these changes

Assignees
No one assigned
Labels
c-update Modifies an existing proposal s-draft This EIP is a Draft t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@OniReimu @eth-bot @Ellajoke @Pandapip1 @xinbenlv